Skip to content
Commit 962a991c authored by Bharath Vedartham's avatar Bharath Vedartham Committed by Dominique Martinet
Browse files

9p/cache.c: Fix memory leak in v9fs_cache_session_get_cookie

v9fs_cache_session_get_cookie assigns a random cachetag to v9ses->cachetag,
if the cachetag is not assigned previously.

v9fs_random_cachetag allocates memory to v9ses->cachetag with kmalloc and uses
scnprintf to fill it up with a cachetag.

But if scnprintf fails, v9ses->cachetag is not freed in the current
code causing a memory leak.

Fix this by freeing v9ses->cachetag it v9fs_random_cachetag fails.

This was reported by syzbot, the link to the report is below:
https://syzkaller.appspot.com/bug?id=f012bdf297a7a4c860c38a88b44fbee43fd9bbf3

Link: http://lkml.kernel.org/r/20190522194519.GA5313@bharath12345-Inspiron-5559


Reported-by: default avatar <syzbot+3a030a73b6c1e9833815@syzkaller.appspotmail.com>
Signed-off-by: default avatarBharath Vedartham <linux.bhar@gmail.com>
Signed-off-by: default avatarDominique Martinet <dominique.martinet@cea.fr>
parent 0ce772fe
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment