Skip to content
Commit 7920af5c authored by Samuel Holland's avatar Samuel Holland Committed by Bartosz Golaszewski
Browse files

gpio: rockchip: Reset int_bothedge when changing trigger



With v2 hardware, an IRQ can be configured to trigger on both edges via
a bit in the int_bothedge register. Currently, the driver sets this bit
when changing the trigger type to IRQ_TYPE_EDGE_BOTH, but fails to reset
this bit if the trigger type is later changed to something else. This
causes spurious IRQs, and when using gpio-keys with wakeup-event-action
set to EV_ACT_(DE)ASSERTED, those IRQs translate into spurious wakeups.

Fixes: 3bcbd1a8 ("gpio/rockchip: support next version gpio controller")
Reported-by: default avatarGuillaume Savaton <guillaume@baierouge.fr>
Tested-by: default avatarGuillaume Savaton <guillaume@baierouge.fr>
Signed-off-by: default avatarSamuel Holland <samuel@sholland.org>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent 754e0b0e
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment