Skip to content
Commit 48a365ae authored by Herve Codina's avatar Herve Codina Committed by Greg Kroah-Hartman
Browse files

i2c: muxes: i2c-mux-pinctrl: Use of_get_i2c_adapter_by_node()



commit 3171d37b upstream.

i2c-mux-pinctrl uses the pair of_find_i2c_adapter_by_node() /
i2c_put_adapter(). These pair alone is not correct to properly lock the
I2C parent adapter.

Indeed, i2c_put_adapter() decrements the module refcount while
of_find_i2c_adapter_by_node() does not increment it. This leads to an
underflow of the parent module refcount.

Use the dedicated function, of_get_i2c_adapter_by_node(), to handle
correctly the module refcount.

Fixes: c4aee3e1 ("i2c: mux: pinctrl: remove platform_data")
Signed-off-by: default avatarHerve Codina <herve.codina@bootlin.com>
Cc: stable@vger.kernel.org
Acked-by: default avatarPeter Rosin <peda@axentia.se>
Reviewed-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 6ec84059
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment