Skip to content
Commit 431280ee authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

ipv4: tcp: send zero IPID for RST and ACK sent in SYN-RECV and TIME-WAIT state



tcp uses per-cpu (and per namespace) sockets (net->ipv4.tcp_sk) internally
to send some control packets.

1) RST packets, through tcp_v4_send_reset()
2) ACK packets in SYN-RECV and TIME-WAIT state, through tcp_v4_send_ack()

These packets assert IP_DF, and also use the hashed IP ident generator
to provide an IPv4 ID number.

Geoff Alexander reported this could be used to build off-path attacks.

These packets should not be fragmented, since their size is smaller than
IPV4_MIN_MTU. Only some tunneled paths could eventually have to fragment,
regardless of inner IPID.

We really can use zero IPID, to address the flaw, and as a bonus,
avoid a couple of atomic operations in ip_idents_reserve()

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Reported-by: default avatarGeoff Alexander <alexandg@cs.unm.edu>
Tested-by: default avatarGeoff Alexander <alexandg@cs.unm.edu>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e500c6d3
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment