Skip to content
Commit 2b86e3aa authored by J. Bruce Fields's avatar J. Bruce Fields
Browse files

nfsd: eliminate an unnecessary acl size limit



We're unnecessarily limiting the size of an ACL to less than what most
filesystems will support.  Some users do hit the limit and it's
confusing and unnecessary.

It still seems prudent to impose some limit on the number of ACEs the
client gives us before passing it straight to kmalloc().  So, let's just
limit it to the maximum number that would be possible given the amount
of data left in the argument buffer.

That will still leave one limit beyond whatever the filesystem imposes:
the client and server negotiate a limit on the size of a request, which
we have to respect.

But we're no longer imposing any additional arbitrary limit.

struct nfs4_ace is 20 bytes on my system and the maximum call size we'll
negotiate is about a megabyte, so in practice this is limiting the
allocation here to about a megabyte.

Reported-by: default avatar"de Vandiere, Louis" <louis.devandiere@atos.net>
Signed-off-by: default avatarJ. Bruce Fields <bfields@redhat.com>
parent 9d60d931
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment