Skip to content
Commit 263782c1 authored by Benjamin LaHaise's avatar Benjamin LaHaise
Browse files

aio: protect reqs_available updates from changes in interrupt handlers

As of commit f8567a38

 it is now possible to
have put_reqs_available() called from irq context.  While put_reqs_available()
is per cpu, it did not protect itself from interrupts on the same CPU.  This
lead to aio_complete() corrupting the available io requests count when run
under a heavy O_DIRECT workloads as reported by Robert Elliott.  Fix this by
disabling irq updates around the per cpu batch updates of reqs_available.

Many thanks to Robert and folks for testing and tracking this down.

Reported-by: default avatarRobert Elliot <Elliott@hp.com>
Tested-by: default avatarRobert Elliot <Elliott@hp.com>
Signed-off-by: default avatarBenjamin LaHaise <bcrl@kvack.org>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@infradead.org>
Cc: stable@vger.kenel.org
parent 1795cd9b
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment