Skip to content
Commit 0c273629 authored by Jeff Layton's avatar Jeff Layton
Browse files

locks: set fl_owner for leases back to current->files

This fixes a regression due to commit 130d1f95 (locks: ensure that
fl_owner is always initialized properly in flock and lease codepaths). I
had mistakenly thought that the fl_owner wasn't used in the lease code,
but I missed the place in __break_lease that does use it.

The i_have_this_lease check in generic_add_lease uses it. While I'm not
sure that check is terribly helpful [1], reset it back to using
current->files in order to ensure that there's no behavior change here.

[1]: leases are owned by the file description. It's possible that this
     is a threaded program, and the lease breaker and the task that
     would handle the signal are different, even if they have the same
     file table. So, there is the potential for false positives with
     this check.

Fixes: 130d1f95

 (locks: ensure that fl_owner is always initialized properly in flock and lease codepaths)
Signed-off-by: default avatarJeff Layton <jlayton@primarydata.com>
parent 962bd40b
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment