Skip to content
Commit 00d39277 authored by Thomas Lukaszewicz's avatar Thomas Lukaszewicz Committed by Chromium LUCI CQ
Browse files

Reland "Implement WebContents discard by clearing the primary frame document"

This is a reland of commit ce4ea269

See diff against PS1.

Addressed timeout issue in DiscardClearsDedicatedWorkers test.
Destruction of blink::DedicatedWorker post Discard() relies on
async GC sweep in V8, which can result in timeouts on bots.

Updated extension tab loading status to report unloaded when the
tab is discarded. The tab will retain its render process when
discarded with the new mechanism (consistent with previous behavior).

Original change's description:
> Implement WebContents discard by clearing the primary frame document
>
> See go/discard-frame-tree for additional details and to contribute
> to discussion.
>
> This carries on from fdoray's prototype (crrev.com/c/4060064) and
> erik's follow up (crrev.com/c/5454457).
>
> This CL introduces a new discard mechanism that avoids needing
> to replace the tab's WebContents.
>
> Discard works by clearing the primary frame tree, done via replacing
> Blink's primary document. This frees resources associated with the
> primary frame and clears away any child frames attached to the
> frame tree.
>
> Discard does not result in creation of any session entries and does
> not emit navigation-related events
>
> Key changes:
>  - Update TabLifecycleUnit::FinishDiscard to no longer create
>    a empty WebContents for the discard operation. Instead discard
>    is implemented via replacing the primary blink document
>
>  - The tab thumbnail implementation has been updated to handle the
>    new discard mechanism
>
>  - OneTimePermissionsTrackerHelper was updated to leverage the
>    existing WebContents observation instead of relying on
>    TabLifecycleObserver
>
>  - Multiple test updates / fixes to reflect discard API changes
>    and address incorrect assumptions (active tabs cannot be
>    discarded)
>
> Notifications for discard events with both the old and new
> WebContents from the original API remain. These can be removed or
> refactored in the follow up CLs.
>
> PERFETTO_TESTS=`autoninja -C out/Default perfetto_diff_tests &&
> out/Default/bin/run_perfetto_diff_tests`
>
> Bug: 347770670
> Change-Id: I32e87b2b992914a7ae0e0bbdddf78f1b27c5773b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5637909


> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
> Reviewed-by: default avatarNicolás Peña <npm@chromium.org>
> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> Reviewed-by: default avatarVictor Vianna <victorvianna@google.com>
> Reviewed-by: default avatarFlorian Jacky <fjacky@chromium.org>
> Reviewed-by: default avatarDavid Pennington <dpenning@chromium.org>
> Reviewed-by: default avatarRakina Zata Amni <rakina@chromium.org>
> Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1343920}

Bug: 347770670
Change-Id: Idba13fec3c375c9f88727826386729963bef9166
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5799663


Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: default avatarVictor Vianna <victorvianna@google.com>
Reviewed-by: default avatarErik Chen <erikchen@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: default avatarFrancois Pierre Doray <fdoray@chromium.org>
Reviewed-by: default avatarFlorian Jacky <fjacky@chromium.org>
Reviewed-by: default avatarNicolás Peña <npm@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarRakina Zata Amni <rakina@chromium.org>
Reviewed-by: default avatarEmilia Paz <emiliapaz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1345153}
parent 897338d0
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment