Skip to content
Commit a3aeb9f0 authored by Peter Lieven's avatar Peter Lieven Committed by Michael Roth
Browse files

thread-pool: add missing qemu_bh_cancel in completion function



commit 3c80ca15 fixed a deadlock scenarion with nested aio_poll invocations.

However, the rescheduling of the completion BH introcuded unnecessary spinning
in the main-loop. On very fast file backends this can even lead to the
"WARNING: I/O thread spun for 1000 iterations" message popping up.

Callgrind reports about 3-4% less instructions with this patch running
qemu-img bench on a ramdisk based VMDK file.

Fixes: 3c80ca15
Cc: qemu-stable@nongnu.org
Signed-off-by: default avatarPeter Lieven <pl@kamp.de>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
(cherry picked from commit b7a745dc)
* drop context dep on b9e413dd
Signed-off-by: default avatarMichael Roth <mdroth@linux.vnet.ibm.com>
parent 34e9c09d
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment