Skip to content
Commit dd4d747e authored by Nadezda Lutovinova's avatar Nadezda Lutovinova Committed by Guenter Roeck
Browse files

hwmon: (w83793) Fix NULL pointer dereference by removing unnecessary structure field



If driver read tmp value sufficient for
(tmp & 0x08) && (!(tmp & 0x80)) && ((tmp & 0x7) == ((tmp >> 4) & 0x7))
from device then Null pointer dereference occurs.
(It is possible if tmp = 0b0xyz1xyz, where same literals mean same numbers)
Also lm75[] does not serve a purpose anymore after switching to
devm_i2c_new_dummy_device() in w83791d_detect_subclients().

The patch fixes possible NULL pointer dereference by removing lm75[].

Found by Linux Driver Verification project (linuxtesting.org).

Cc: stable@vger.kernel.org
Signed-off-by: default avatarNadezda Lutovinova <lutovinova@ispras.ru>
Link: https://lore.kernel.org/r/20210921155153.28098-3-lutovinova@ispras.ru


[groeck: Dropped unnecessary continuation lines, fixed multi-line alignments]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 0f36b881
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment