Skip to content
Commit 3d0bc44d authored by Norbert Slusarek's avatar Norbert Slusarek Committed by Jakub Kicinski
Browse files

net/vmw_vsock: improve locking in vsock_connect_timeout()



A possible locking issue in vsock_connect_timeout() was recognized by
Eric Dumazet which might cause a null pointer dereference in
vsock_transport_cancel_pkt(). This patch assures that
vsock_transport_cancel_pkt() will be called within the lock, so a race
condition won't occur which could result in vsk->transport to be set to NULL.

Fixes: 380feae0 ("vsock: cancel packets when failing to connect")
Reported-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarNorbert Slusarek <nslusarek@gmx.net>
Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
Link: https://lore.kernel.org/r/trinity-f8e0937a-cf0e-4d80-a76e-d9a958ba3ef1-1612535522360@3c-app-gmx-bap12


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5d1cbcc9
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment