Skip to content
Unverified Commit f89ea63f authored by David Howells's avatar David Howells Committed by Christian Brauner
Browse files

netfs, 9p: Fix race between umount and async request completion



There's a problem in 9p's interaction with netfslib whereby a crash occurs
because the 9p_fid structs get forcibly destroyed during client teardown
(without paying attention to their refcounts) before netfslib has finished
with them.  However, it's not a simple case of deferring the clunking that
p9_fid_put() does as that requires the p9_client record to still be
present.

The problem is that netfslib has to unlock pages and clear the IN_PROGRESS
flag before destroying the objects involved - including the fid - and, in
any case, nothing checks to see if writeback completed barring looking at
the page flags.

Fix this by keeping a count of outstanding I/O requests (of any type) and
waiting for it to quiesce during inode eviction.

Reported-by: default avatar <syzbot+df038d463cca332e8414@syzkaller.appspotmail.com>
Link: https://lore.kernel.org/all/0000000000005be0aa061846f8d6@google.com/
Reported-by: default avatar <syzbot+d7c7a495a5e466c031b6@syzkaller.appspotmail.com>
Link: https://lore.kernel.org/all/000000000000b86c5e06130da9c6@google.com/
Reported-by: default avatar <syzbot+1527696d41a634cc1819@syzkaller.appspotmail.com>
Link: https://lore.kernel.org/all/000000000000041f960618206d7e@google.com/
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/755891.1716560771@warthog.procyon.org.uk
Tested-by: default avatar <syzbot+d7c7a495a5e466c031b6@syzkaller.appspotmail.com>
Reviewed-by: default avatarDominique Martinet <asmadeus@codewreck.org>
cc: Eric Van Hensbergen <ericvh@kernel.org>
cc: Latchesar Ionkov <lucho@ionkov.net>
cc: Christian Schoenebeck <linux_oss@crudebyte.com>
cc: Jeff Layton <jlayton@kernel.org>
cc: Steve French <sfrench@samba.org>
cc: Hillf Danton <hdanton@sina.com>
cc: v9fs@lists.linux.dev
cc: linux-afs@lists.infradead.org
cc: linux-cifs@vger.kernel.org
cc: netfs@lists.linux.dev
cc: linux-fsdevel@vger.kernel.org
Reported-and-tested-by: default avatar <syzbot+d7c7a495a5e466c031b6@syzkaller.appspotmail.com>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 29be9100
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment