Skip to content
Commit f8510d67 authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Luca Coelho
Browse files

iwlwifi: mvm: Change an 'else if' into an 'else' in iwl_mvm_send_add_bcast_sta



When building with -Wsometimes-uninitialized, Clang warns:

drivers/net/wireless/intel/iwlwifi/mvm/sta.c:2114:12: warning: variable
'queue' is used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]

Clang can't evaluate at this point that WARN(1, ...) always returns true
because __ret_warn_on is defined as !!(condition), which isn't
immediately evaluated as 1. Change this branch to else so that it's
clear to Clang that we intend to bail out here.

Link: https://github.com/ClangBuiltLinux/linux/issues/399
Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
[added a few more braces]
Signed-off-by: default avatarLuca Coelho <luciano.coelho@intel.com>
parent 2644f9d0
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment