Skip to content
Commit efc3dbc3 authored by David S. Miller's avatar David S. Miller
Browse files

rds: Make rds_sock_lock BH rather than IRQ safe.



rds_sock_info() triggers locking warnings because we try to perform a
local_bh_enable() (via sock_i_ino()) while hardware interrupts are
disabled (via taking rds_sock_lock).

There is no reason for rds_sock_lock to be a hardware IRQ disabling
lock, none of these access paths run in hardware interrupt context.

Therefore making it a BH disabling lock is safe and sufficient to
fix this bug.

Reported-by: default avatarKumar Sanghvi <kumaras@chelsio.com>
Reported-by: default avatarJosh Boyer <jwboyer@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 36a12119
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment