Skip to content
Commit de55a7e7 authored by Necip Fazil Yildiran's avatar Necip Fazil Yildiran Committed by Greg Kroah-Hartman
Browse files

net: qrtr: fix usage of idr in port assignment to socket



[ Upstream commit 8dfddfb7 ]

Passing large uint32 sockaddr_qrtr.port numbers for port allocation
triggers a warning within idr_alloc() since the port number is cast
to int, and thus interpreted as a negative number. This leads to
the rejection of such valid port numbers in qrtr_port_assign() as
idr_alloc() fails.

To avoid the problem, switch to idr_alloc_u32() instead.

Fixes: bdabad3e ("net: Add Qualcomm IPC router")
Reported-by: default avatar <syzbot+f31428628ef672716ea8@syzkaller.appspotmail.com>
Signed-off-by: default avatarNecip Fazil Yildiran <necip@google.com>
Reviewed-by: default avatarDmitry Vyukov <dvyukov@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 206cac12
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment