Skip to content
Commit d80a8f1b authored by David Howells's avatar David Howells Committed by Christian Brauner
Browse files

vfs, security: Fix automount superblock LSM init problem, preventing NFS sb sharing



When NFS superblocks are created by automounting, their LSM parameters
aren't set in the fs_context struct prior to sget_fc() being called,
leading to failure to match existing superblocks.

This bug leads to messages like the following appearing in dmesg when
fscache is enabled:

    NFS: Cache volume key already in use (nfs,4.2,2,108,106a8c0,1,,,,100000,100000,2ee,3a98,1d4c,3a98,1)

Fix this by adding a new LSM hook to load fc->security for submount
creation.

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
Link: https://lore.kernel.org/r/165962680944.3334508.6610023900349142034.stgit@warthog.procyon.org.uk/ # v1
Link: https://lore.kernel.org/r/165962729225.3357250.14350728846471527137.stgit@warthog.procyon.org.uk/ # v2
Link: https://lore.kernel.org/r/165970659095.2812394.6868894171102318796.stgit@warthog.procyon.org.uk/ # v3
Link: https://lore.kernel.org/r/166133579016.3678898.6283195019480567275.stgit@warthog.procyon.org.uk/ # v4
Link: https://lore.kernel.org/r/217595.1662033775@warthog.procyon.org.uk/

 # v5
Fixes: 9bc61ab1 ("vfs: Introduce fs_context, switch vfs_kern_mount() to it.")
Fixes: 779df6a5 ("NFS: Ensure security label is set for root inode")
Tested-by: default avatarJeff Layton <jlayton@kernel.org>
Acked-by: default avatarCasey Schaufler <casey@schaufler-ca.com>
Acked-by: default avatar"Christian Brauner (Microsoft)" <brauner@kernel.org>
Acked-by: default avatarPaul Moore <paul@paul-moore.com>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Message-Id: <20230808-master-v9-1-e0ecde888221@kernel.org>
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 4352b8cd
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment