Skip to content
Commit cd41ec23 authored by Hao Ge's avatar Hao Ge Committed by Greg Kroah-Hartman
Browse files

fs: fix undefined behavior in bit shift for SB_NOUSER

commit f15afbd3 upstream.

Shifting signed 32-bit value by 31 bits is undefined, so changing
significant bit to unsigned. It was spotted by UBSAN.

So let's just fix this by using the BIT() helper for all SB_* flags.

Fixes: e462ec50

 ("VFS: Differentiate mount flags (MS_*) from internal superblock flags")
Signed-off-by: default avatarHao Ge <gehao@kylinos.cn>
Message-Id: <20230424051835.374204-1-gehao@kylinos.cn>
[brauner@kernel.org: use BIT() for all SB_* flags]
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent c2f65991
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment