Skip to content
Commit c60c1522 authored by Martin Faltesek's avatar Martin Faltesek Committed by Jakub Kicinski
Browse files

nfc: st-nci: fix incorrect validating logic in EVT_TRANSACTION



The first validation check for EVT_TRANSACTION has two different checks
tied together with logical AND. One is a check for minimum packet length,
and the other is for a valid aid_tag. If either condition is true (fails),
then an error should be triggered. The fix is to change && to ||.

Reported-by: default avatarDenis Efremov <denis.e.efremov@oracle.com>
Reviewed-by: default avatarGuenter Roeck <groeck@google.com>
Fixes: 5d1ceb7f

 ("NFC: st21nfcb: Add HCI transaction event support")
Signed-off-by: default avatarMartin Faltesek <mfaltesek@google.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 06ccc8ec
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment