Skip to content
Commit b9fc828d authored by Manish Chopra's avatar Manish Chopra Committed by David S. Miller
Browse files

qede: Fix barrier usage after tx doorbell write.



Since commit c5ad119f
("net: sched: pfifo_fast use skb_array") driver is exposed
to an issue where it is hitting NULL skbs while handling TX
completions. Driver uses mmiowb() to flush the writes to the
doorbell bar which is a write-combined bar, however on x86
mmiowb() does not flush the write combined buffer.

This patch fixes this problem by replacing mmiowb() with wmb()
after the write combined doorbell write so that writes are
flushed and synchronized from more than one processor.

V1->V2:
-------
This patch was marked as "superseded" in patchwork.
(Not really sure for what reason).Resending it as v2.

Signed-off-by: default avatarAriel Elior <ariel.elior@cavium.com>
Signed-off-by: default avatarManish Chopra <manish.chopra@cavium.com>

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent dc6455a7
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment