Skip to content
Commit b0391479 authored by Thierry Reding's avatar Thierry Reding Committed by Bartosz Golaszewski
Browse files

gpio: max77620: Fixup debounce delays



When converting milliseconds to microseconds in commit fffa6af9
("gpio: max77620: Use correct unit for debounce times") some ~1 ms gaps
were introduced between the various ranges supported by the controller.
Fix this by changing the start of each range to the value immediately
following the end of the previous range. This way a debounce time of,
say 8250 us will translate into 16 ms instead of returning an -EINVAL
error.

Typically the debounce delay is only ever set through device tree and
specified in milliseconds, so we can never really hit this issue because
debounce times are always a multiple of 1000 us.

The only notable exception for this is drivers/mmc/host/mmc-spi.c where
the CD GPIO is requested, which passes a 1 us debounce time. According
to a comment preceeding that code this should actually be 1 ms (i.e.
1000 us).

Reported-by: default avatarPavel Machek <pavel@denx.de>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
Acked-by: default avatarPavel Machek <pavel@denx.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 31f4f5b4
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment