Skip to content
Commit 6862b278 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Paul Gortmaker
Browse files

soc: renesas: Add missing check for non-zero product register address



commit 4194b583 upstream.

If the DTB for a device with an RZ/A2 SoC lacks a device node for the
BSID register, the ID validation code falls back to using a register at
address 0x0, which leads to undefined behavior (e.g. reading back a
random value).

This could be fixed by letting fam_rza2.reg point to the actual BSID
register.  However, the hardcoded fallbacks were meant for backwards
compatibility with old DTBs only, not for new SoCs.  Hence fix this by
validating renesas_family.reg before using it.

Fixes: 175f435f ("soc: renesas: identify RZ/A2")
Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20191016143306.28995-1-geert+renesas@glider.be


Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
parent c1582ec3
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment