Skip to content
Commit 647037ad authored by Aaron Thompson's avatar Aaron Thompson Committed by Mike Rapoport (IBM)
Browse files

Revert "mm: Always release pages to the buddy allocator in memblock_free_late()."



This reverts commit 115d9d77.

The pages being freed by memblock_free_late() have already been
initialized, but if they are in the deferred init range,
__free_one_page() might access nearby uninitialized pages when trying to
coalesce buddies. This can, for example, trigger this BUG:

  BUG: unable to handle page fault for address: ffffe964c02580c8
  RIP: 0010:__list_del_entry_valid+0x3f/0x70
   <TASK>
   __free_one_page+0x139/0x410
   __free_pages_ok+0x21d/0x450
   memblock_free_late+0x8c/0xb9
   efi_free_boot_services+0x16b/0x25c
   efi_enter_virtual_mode+0x403/0x446
   start_kernel+0x678/0x714
   secondary_startup_64_no_verify+0xd2/0xdb
   </TASK>

A proper fix will be more involved so revert this change for the time
being.

Fixes: 115d9d77 ("mm: Always release pages to the buddy allocator in memblock_free_late().")
Signed-off-by: default avatarAaron Thompson <dev@aaront.org>
Link: https://lore.kernel.org/r/20230207082151.1303-1-dev@aaront.org


Signed-off-by: default avatarMike Rapoport (IBM) <rppt@kernel.org>
parent 4ec5183e
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment