Skip to content
Commit 64176843 authored by Masami Hiramatsu (Google)'s avatar Masami Hiramatsu (Google) Committed by Greg Kroah-Hartman
Browse files

kprobes/x86: Use copy_from_kernel_nofault() to read from unsafe address

[ Upstream commit 4e51653d ]

Read from an unsafe address with copy_from_kernel_nofault() in
arch_adjust_kprobe_addr() because this function is used before checking
the address is in text or not. Syzcaller bot found a bug and reported
the case if user specifies inaccessible data area,
arch_adjust_kprobe_addr() will cause a kernel panic.

[ mingo: Clarified the comment. ]

Fixes: cc66bb91

 ("x86/ibt,kprobes: Cure sym+0 equals fentry woes")
Reported-by: default avatarQiang Zhang <zzqq0103.hey@gmail.com>
Tested-by: default avatarJinghao Jia <jinghao7@illinois.edu>
Signed-off-by: default avatarMasami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/171042945004.154897.2221804961882915806.stgit@devnote2


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent dc33e92a
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment