Skip to content
Commit 4b0c5479 authored by Ard Biesheuvel's avatar Ard Biesheuvel Committed by Sasha Levin
Browse files

x86/efistub: Don't clear BSS twice in mixed mode

[ Upstream commit df7ecce8 ]

Clearing BSS should only be done once, at the very beginning.
efi_pe_entry() is the entrypoint from the firmware, which may not clear
BSS and so it is done explicitly. However, efi_pe_entry() is also used
as an entrypoint by the mixed mode startup code, in which case BSS will
already have been cleared, and doing it again at this point will corrupt
global variables holding the firmware's GDT/IDT and segment selectors.

So make the memset() conditional on whether the EFI stub is running in
native mode.

Fixes: b3810c5a

 ("x86/efistub: Clear decompressor BSS in native EFI entrypoint")
Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent f07ffd18
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment