Skip to content
Commit 391e982b authored by Alexey Dobriyan's avatar Alexey Dobriyan Committed by Luis Chamberlain
Browse files

module: fix [e_shstrndx].sh_size=0 OOB access

It is trivial to craft a module to trigger OOB access in this line:

	if (info->secstrings[strhdr->sh_size - 1] != '\0') {

BUG: unable to handle page fault for address: ffffc90000aa0fff
PGD 100000067 P4D 100000067 PUD 100066067 PMD 10436f067 PTE 0
Oops: 0000 [#1] PREEMPT SMP PTI
CPU: 7 PID: 1215 Comm: insmod Not tainted 5.18.0-rc5-00007-g9bf578647087-dirty #10
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.14.0-4.fc34 04/01/2014
RIP: 0010:load_module+0x19b/0x2391

Fixes: ec2a2959

 ("module: harden ELF info handling")
Signed-off-by: default avatarAlexey Dobriyan <adobriyan@gmail.com>
[rebased patch onto modules-next]
Signed-off-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
parent 99bd9956
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment