Skip to content
Commit 335a42eb authored by Petr Mladek's avatar Petr Mladek Committed by Tejun Heo
Browse files

workqueue: Fix hung time report of worker pools



The workqueue watchdog prints a warning when there is no progress in
a worker pool. Where the progress means that the pool started processing
a pending work item.

Note that it is perfectly fine to process work items much longer.
The progress should be guaranteed by waking up or creating idle
workers.

show_one_worker_pool() prints state of non-idle worker pool. It shows
a delay since the last pool->watchdog_ts.

The timestamp is updated when a first pending work is queued in
__queue_work(). Also it is updated when a work is dequeued for
processing in worker_thread() and rescuer_thread().

The delay is misleading when there is no pending work item. In this
case it shows how long the last work item is being proceed. Show
zero instead. There is no stall if there is no pending work.

Fixes: 82607adc ("workqueue: implement lockup detector")
Signed-off-by: default avatarPetr Mladek <pmladek@suse.com>
Signed-off-by: default avatarTejun Heo <tj@kernel.org>
parent a8ec5880
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment