Skip to content
Commit 2844e243 authored by Sondhauß, Jan's avatar Sondhauß, Jan Committed by Jakub Kicinski
Browse files

drivers: ethernet: cpsw: fix panic when interrupt coaleceing is set via ethtool



cpsw_ethtool_begin directly returns the result of pm_runtime_get_sync
when successful.
pm_runtime_get_sync returns -error code on failure and 0 on successful
resume but also 1 when the device is already active. So the common case
for cpsw_ethtool_begin is to return 1. That leads to inconsistent calls
to pm_runtime_put in the call-chain so that pm_runtime_put is called
one too many times and as result leaving the cpsw dev behind suspended.

The suspended cpsw dev leads to an access violation later on by
different parts of the cpsw driver.

Fix this by calling the return-friendly pm_runtime_resume_and_get
function.

Fixes: d43c65b0 ("ethtool: runtime-resume netdev parent in ethnl_ops_begin")
Signed-off-by: default avatarJan Sondhauss <jan.sondhauss@wago.com>
Reviewed-by: default avatarVignesh Raghavendra <vigneshr@ti.com>
Link: https://lore.kernel.org/r/20220323084725.65864-1-jan.sondhauss@wago.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 054d5575
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment