Skip to content
Commit 13c088cf authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Vinod Koul
Browse files

phy: hisilicon: Fix an out of bounds check in hisi_inno_phy_probe()



The size of array 'priv->ports[]' is INNO_PHY_PORT_NUM.

In the for loop, 'i' is used as the index for array 'priv->ports[]'
with a check (i > INNO_PHY_PORT_NUM) which indicates that
INNO_PHY_PORT_NUM is allowed value for 'i' in the same loop.

This > comparison needs to be changed to >=, otherwise it potentially leads
to an out of bounds write on the next iteration through the loop

Fixes: ba8b0ee8 ("phy: add inno-usb2-phy driver for hi3798cv200 SoC")
Reported-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20230721090558.3588613-1-harshit.m.mogalapalli@oracle.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 8932089b
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment