Skip to content
Commit 0113d9c9 authored by Kyle Zeng's avatar Kyle Zeng Committed by David S. Miller
Browse files

ipv4: fix null-deref in ipv4_link_failure



Currently, we assume the skb is associated with a device before calling
__ip_options_compile, which is not always the case if it is re-routed by
ipvs.
When skb->dev is NULL, dev_net(skb->dev) will become null-dereference.
This patch adds a check for the edge case and switch to use the net_device
from the rtable when skb->dev is NULL.

Fixes: ed0de45a ("ipv4: recompile ip options in ipv4_link_failure")
Suggested-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarKyle Zeng <zengyhkyle@gmail.com>
Cc: Stephen Suryaputra <ssuryaextr@gmail.com>
Cc: Vadim Fedorenko <vfedorenko@novek.ru>
Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cb47b1f6
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment