Skip to content
  1. Apr 24, 2021
    • Mark Brown's avatar
      ASoC: simple-card: Fix breakage on kontron-sl28-var3-ads2 · 25c4a9b6
      Mark Brown authored
      A KernelCI bisection identified 59c35c44 "ASoC: simple-card: add
      simple_parse_node()" as causing simple-card to fail to instantiate on
      kontron-sl28-var3-ads2 systems.  Since the merge window is expected to
      open over the weekend drop that commit and subsequent ones which depend
      on it for now in case other systems are affected too.
      
      The boot log showed the error as:
      
      <4>[    9.948821] sysfs: cannot create duplicate filename '/devices/platform/sound/(null)-wm8904-hifi'
      
      (backtrace)
      
      <3>[   10.191982] kobject_add_internal failed for (null)-wm8904-hifi with -EEXIST, don't try to register things with the same name in the same directory.
      
      The dropped commits are:
      
      73371bac "ASoC: audio-graph: tidyup graph_dai_link_of_dpcm()"
      43439227 "ASoC: simple-card: add simple_link_init()"
      59c35c44
      
       "ASoC: simple-card: add simple_parse_node()"
      
      Reported-by: default avatarGuillaume Tucker <guillaume.tucker@collabora.com>
      Reported-by: default avatar"kernelci.org bot" <bot@kernelci.org>
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      25c4a9b6
  2. Apr 23, 2021
  3. Apr 22, 2021
    • Arnd Bergmann's avatar
      ASoC: tegra: mark runtime-pm functions as __maybe_unused · ccd4cc3e
      Arnd Bergmann authored
      A reorganization of the driver source led to two of them causing
      a compile time warning in some configurations:
      
      tegra/tegra20_spdif.c:36:12: error: 'tegra20_spdif_runtime_resume' defined but not used [-Werror=unused-function]
         36 | static int tegra20_spdif_runtime_resume(struct device *dev)
            |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      tegra/tegra20_spdif.c:27:12: error: 'tegra20_spdif_runtime_suspend' defined but not used [-Werror=unused-function]
         27 | static int tegra20_spdif_runtime_suspend(struct device *dev)
            |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      tegra/tegra30_ahub.c:64:12: error: 'tegra30_ahub_runtime_resume' defined but not used [-Werror=unused-function]
         64 | static int tegra30_ahub_runtime_resume(struct device *dev)
            |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
      tegra/tegra30_ahub.c:43:12: error: 'tegra30_ahub_runtime_suspend' defined but not used [-Werror=unused-function]
         43 | static int tegra30_ahub_runtime_suspend(struct device *dev)
            |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      
      Mark these functions as __maybe_unused to avoid this kind of warning.
      
      Fixes: b5571449 ("ASoC: tegra30: ahub: Remove handing of disabled runtime PM")
      Fixes: c53b396f ("ASoC: tegra20: spdif: Remove handing of disabled runtime PM")
      Fixes: 80ec4a4c ("ASoC: tegra20: i2s: Remove handing of disabled runtime PM")
      Fixes: b5f6f781
      
       ("ASoC: tegra30: i2s: Remove handing of disabled runtime PM")
      Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      Link: https://lore.kernel.org/r/20210422133418.1757893-1-arnd@kernel.org
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      ccd4cc3e
  4. Apr 21, 2021
  5. Apr 20, 2021
    • Thierry Reding's avatar
      ASoC: simple-card-utils: Allocate link info structure on heap · ec1af6c6
      Thierry Reding authored
      struct link_info can grow fairly large and may cause the stack frame
      size to be exceeded when allocated on the stack. Some architectures
      such as 32-bit ARM, RISC-V or PowerPC have small stack frames where
      this causes a compiler warning, so allocate these structures on the
      heap instead of the stack.
      
      Fixes: 343e55e7
      
       ("ASoC: simple-card-utils: Increase maximum number of links to 128")
      Reported-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Reported-by: default avatarStephen Rothwell <sfr@canb.auug.org.au>
      Reported-by: default avatarkernel test robot <lkp@intel.com>
      Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
      Acked-by: default avatarKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Link: https://lore.kernel.org/r/20210419164117.1422242-1-thierry.reding@gmail.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      ec1af6c6
    • Jack Yu's avatar
      ASoC: rt1015p: add support on format S32_LE · 7f51384f
      Jack Yu authored
      
      
      Add support on format S32_LE for rt1015p.
      
      Signed-off-by: default avatarJack Yu <jack.yu@realtek.com>
      Link: https://lore.kernel.org/r/377f0ee05d514c66b567eb6385ac7753@realtek.com
      Signed-off-by: default avatarMark Brown <broonie@kernel.org>
      7f51384f
    • Mark Brown's avatar
      Merge series "ASoC: rt286/rt298: Fixes for DMIC2 config and combo jack" from... · 4b1013f4
      Mark Brown authored
      Merge series "ASoC: rt286/rt298: Fixes for DMIC2 config and combo jack" from David Ward <david.ward@gatech.edu>:
      
      The last two patches in this series fix a longstanding issue that prevented
      the ALC3263 codec from using a headset mic. This codec can be found on Dell
      systems including the Latitude 13 7350, Venue 11 Pro 7140, and XPS 13 9343.
      In fact, there is an ACPI quirk for the XPS 13 9343, which forces it to use
      legacy HD Audio just to avoid this issue:
      
      https://lore.kernel.org/alsa-devel/CAPeXnHv07HkvcHrYFmZMr8OTp7U7F=k_k=LPYnUtp89iPn2d2Q@mail.gmail.com/
      
      This may allow that ACPI quirk to be removed. Either way, the other systems
      mentioned above do not support this quirk and already use the ASoC driver,
      so this fix is necessary for headset mic support on those systems.
      
      Note: there is likely other handling for this codec that only exists in the
      HDA driver, but which also belongs in the ASoC driver. Commit 394c97f8
      
      
      ("ALSA: hda/realtek - Change EAPD to verb control") describes an issue that
      does not seem to be resolved in the ASoC driver, to give an example.
      
      Other patches in this series are not specific to the ALC3263. These patches
      set the correct combo jack configuration when headphones are inserted, and
      fix a misaligned value set in the DMIC2 Configuration Default register.
      
      BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=114171
      BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=150601
      BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=205961
      Signed-off-by: default avatarDavid Ward <david.ward@gatech.edu>
      
      David Ward (5):
        ASoC: rt286: Fix upper byte in DMIC2 configuration
        ASoC: rt286: Configure combo jack for headphones
        ASoC: rt298: Configure combo jack for headphones
        ASoC: rt286: Make RT286_SET_GPIO_* readable and writable
        ASoC: rt286: Generalize support for ALC3263 codec
      
       sound/soc/codecs/rt286.c | 34 +++++++++++++++++++++-------------
       sound/soc/codecs/rt298.c |  9 +++++++--
       2 files changed, 28 insertions(+), 15 deletions(-)
      
      --
      2.31.1
      4b1013f4
  6. Apr 19, 2021
  7. Apr 17, 2021