Skip to content
Commit 9f393a2d authored by Neha Malcom Francis's avatar Neha Malcom Francis Committed by Tom Rini
Browse files

board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte



EEPROM detection logic in ti_i2c_eeprom_get() involves figuring out
whether addressing is 1-byte or 2-byte. There are currently different
behaviours seen across boards as documented in commit bf637664
("board: ti: common: board_detect: Fix EEPROM read quirk"). Adding to
the list, we see that there are 2-byte EEPROMs that read properly
with 1-byte addressing with no offset.

For ti_i2c_eeprom_am6_get where eeprom parse operation is dynamic, the
earlier commit d2ab2a2b ("board: ti: common: board_detect: Fix
EEPROM read quirk for AM6 style data") tried to resolve this by running
ti_i2c_eeprom_get() twice. However this commit along with its former
commit fails on J7 platforms where EEPROM successfully return back the
header on 1-byte addressing and continues to do so until an offset is
introduced. So the second read incorrectly determines the EEPROM as
1-byte addressing.

A more generic solution is introduced here to solve
this issue: 1-byte read without offset and 1-byte read with offset. If
both passes, it follows 1-byte addressing else we proceed with 2-byte
addressing check.

Tested on J721E, J7200, DRA7xx, AM64x

Signed-off-by: default avatarNeha Malcom Francis <n-francis@ti.com>
Fixes: d2ab2a2b (board: ti: common: board_detect: Fix EEPROM read quirk for AM6 style data)
Fixes: bf637664 (board: ti: common: board_detect: Fix EEPROM read quirk)
Tested-By: default avatarMatwey V. Kornilov <matwey.kornilov@gmail.com>
parent 357c352c
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment