Commit fffe9bee authored by Bob Peterson's avatar Bob Peterson
Browse files

gfs2: Delay withdraw from atomic context 



Before this patch, if function __gfs2_ail_flush detected an error
syncing the ail list, it call gfs2_ail_error which called gfs2_withdraw.
Since __gfs2_ail_flush deals with a specific glock, we shouldn't withdraw
immediately because the withdraw code (signal_our_withdraw) uses glocks
in its processing.

This patch changes the call from gfs2_withdraw to gfs2_withdraw_delayed
which defers the withdraw until a more appropriate context, such as the
logd daemon, discovers the intent to withdraw.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
parent d1340f80

fs/gfs2/glops.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -44,7 +44,7 @@ static void gfs2_ail_error(struct gfs2_glock *gl, const struct buffer_head *bh) 
	       gl->gl_name.ln_type, gl->gl_name.ln_number,

	       gl->gl_name.ln_type, gl->gl_name.ln_number,

	       gfs2_glock2aspace(gl));

	       gfs2_glock2aspace(gl));

	gfs2_lm(sdp, "AIL error\n");

	gfs2_lm(sdp, "AIL error\n");

	gfs2_withdraw(sdp);

	gfs2_withdraw_delayed(sdp);

}

}





/**

/**