Commit fffe799b authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Herbert Xu
Browse files

crypto: qat - don't cast parameter in bit operations 



While in this particular case it would not be a (critical) issue,
the pattern itself is bad and error prone in case the location
of the parameter is changed.

Don't cast parameter to unsigned long pointer in the bit operations.
Instead copy to a local variable on stack of a proper type and use.

Fixes: b4b7e67c ("crypto: qat - Intel(R) QAT ucode part of fw loader")
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarGiovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 4ba31cdd

drivers/crypto/qat/qat_common/qat_uclo.c

+6 −3
Original line number Diff line number Diff line
@@ -387,7 +387,9 @@ static int qat_uclo_init_ustore(struct icp_qat_fw_loader_handle *handle, 
	page = image->page;



	for_each_set_bit(ae, &ae_mask, handle->hal_handle->ae_max_num) {

		if (!test_bit(ae, (unsigned long *)&uof_image->ae_assigned))

		unsigned long ae_assigned = uof_image->ae_assigned;



		if (!test_bit(ae, &ae_assigned))

			continue;



		if (!test_bit(ae, &cfg_ae_mask))
@@ -664,8 +666,9 @@ static int qat_uclo_map_ae(struct icp_qat_fw_loader_handle *handle, int max_ae) 
			continue;



		for (i = 0; i < obj_handle->uimage_num; i++) {

			if (!test_bit(ae, (unsigned long *)

			&obj_handle->ae_uimage[i].img_ptr->ae_assigned))

			unsigned long ae_assigned = obj_handle->ae_uimage[i].img_ptr->ae_assigned;



			if (!test_bit(ae, &ae_assigned))

				continue;

			mflag = 1;

			if (qat_uclo_init_ae_data(obj_handle, ae, i))