Commit ffc9f9bf authored by John Garry's avatar John Garry Committed by Martin K. Petersen
Browse files

scsi: mvsas: Delete mvs_tag_init() 



All mvs_tag_init() does is zero the tag bitmap, but this is already done
with the kzalloc() call to alloc the tags, so delete this unneeded
function.

Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Link: https://lore.kernel.org/r/1666091763-11023-7-git-send-email-john.garry@huawei.com


Reviewed-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 6472cfb4

drivers/scsi/mvsas/mv_init.c

+0 −2
Original line number Diff line number Diff line
@@ -286,8 +286,6 @@ static int mvs_alloc(struct mvs_info *mvi, struct Scsi_Host *shost) 
	}

	mvi->tags_num = slot_nr;



	/* Initialize tags */

	mvs_tag_init(mvi);

	return 0;

err_out:

	return 1;

drivers/scsi/mvsas/mv_sas.c

+0 −7
Original line number Diff line number Diff line
@@ -51,13 +51,6 @@ inline int mvs_tag_alloc(struct mvs_info *mvi, u32 *tag_out) 
	return 0;

}



void mvs_tag_init(struct mvs_info *mvi)

{

	int i;

	for (i = 0; i < mvi->tags_num; ++i)

		mvs_tag_clear(mvi, i);

}



static struct mvs_info *mvs_find_dev_mvi(struct domain_device *dev)

{

	unsigned long i = 0, j = 0, hi = 0;

drivers/scsi/mvsas/mv_sas.h

+0 −1
Original line number Diff line number Diff line
@@ -428,7 +428,6 @@ void mvs_tag_clear(struct mvs_info *mvi, u32 tag); 
void mvs_tag_free(struct mvs_info *mvi, u32 tag);

void mvs_tag_set(struct mvs_info *mvi, unsigned int tag);

int mvs_tag_alloc(struct mvs_info *mvi, u32 *tag_out);

void mvs_tag_init(struct mvs_info *mvi);

void mvs_iounmap(void __iomem *regs);

int mvs_ioremap(struct mvs_info *mvi, int bar, int bar_ex);

void mvs_phys_reset(struct mvs_info *mvi, u32 phy_mask, int hard);