Commit ffc9c3eb authored by Petko Manolov's avatar Petko Manolov Committed by David S. Miller
Browse files

net: usb: pegasus: fixes of set_register(s) return value evaluation; 



- restore the behavior in enable_net_traffic() to avoid regressions - Jakub
    Kicinski;
  - hurried up and removed redundant assignment in pegasus_open() before yet
    another checker complains;

Fixes: 8a160e2e ("net: usb: pegasus: Check the return value of get_geristers() and friends;")
Reported-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarPetko Manolov <petko.manolov@konsulko.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7e78c597

drivers/net/usb/pegasus.c

+2 −2
Original line number Diff line number Diff line
@@ -446,7 +446,7 @@ static int enable_net_traffic(struct net_device *dev, struct usb_device *usb) 
		write_mii_word(pegasus, 0, 0x1b, &auxmode);

	}



	return 0;

	return ret;

fail:

	netif_dbg(pegasus, drv, pegasus->net, "%s failed\n", __func__);

	return ret;
@@ -835,7 +835,7 @@ static int pegasus_open(struct net_device *net) 
	if (!pegasus->rx_skb)

		goto exit;



	res = set_registers(pegasus, EthID, 6, net->dev_addr);

	set_registers(pegasus, EthID, 6, net->dev_addr);



	usb_fill_bulk_urb(pegasus->rx_urb, pegasus->usb,

			  usb_rcvbulkpipe(pegasus->usb, 1),