Commit ffa28312 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

firmware_loader: Fix a NULL vs IS_ERR() check 



The crypto_alloc_shash() function doesn't return NULL, it returns
error pointers.  Update the check accordingly.

Fixes: 02fe26f2 ("firmware_loader: Add debug message with checksum for FW file")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Acked-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
Link: https://lore.kernel.org/r/36ef6042-ce74-4e8e-9e2c-5b5c28940610@kili.mountain


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 71698da3

drivers/base/firmware_loader/main.c

+1 −1
Original line number Diff line number Diff line
@@ -812,7 +812,7 @@ static void fw_log_firmware_info(const struct firmware *fw, const char *name, st 
	char *outbuf;



	alg = crypto_alloc_shash("sha256", 0, 0);

	if (!alg)

	if (IS_ERR(alg))

		return;



	sha256buf = kmalloc(SHA256_DIGEST_SIZE, GFP_KERNEL);