Commit ff763011 authored by Wenjuan Geng's avatar Wenjuan Geng Committed by Paolo Abeni
Browse files

nfp: flower: support case of match on ct_state(0/0x3f) 



is_post_ct_flow() function will process only ct_state ESTABLISHED,
then offload_pre_check() function will check FLOW_DISSECTOR_KEY_CT flag.
When config tc filter match ct_state(0/0x3f), dissector->used_keys
with FLOW_DISSECTOR_KEY_CT bit, function offload_pre_check() will
return false, so not offload. This is a special case that can be handled
safely.

Therefore, modify to let initial packet which won't go through conntrack
can be offloaded, as long as the cared ct fields are all zero.

Signed-off-by: default avatarWenjuan Geng <wenjuan.geng@corigine.com>
Reviewed-by: default avatarLouis Peens <louis.peens@corigine.com>
Signed-off-by: default avatarSimon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20220823090122.403631-1-simon.horman@corigine.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 35ffb665

drivers/net/ethernet/netronome/nfp/flower/offload.c

+7 −2
Original line number Diff line number Diff line
@@ -1301,9 +1301,14 @@ static bool offload_pre_check(struct flow_cls_offload *flow) 
{

	struct flow_rule *rule = flow_cls_offload_flow_rule(flow);

	struct flow_dissector *dissector = rule->match.dissector;

	struct flow_match_ct ct;



	if (dissector->used_keys & BIT(FLOW_DISSECTOR_KEY_CT))

	if (dissector->used_keys & BIT(FLOW_DISSECTOR_KEY_CT)) {

		flow_rule_match_ct(rule, &ct);

		/* Allow special case where CT match is all 0 */

		if (memchr_inv(ct.key, 0, sizeof(*ct.key)))

			return false;

	}



	if (flow->common.chain_index)

		return false;