Commit ff62b8e6 authored by Greg Kroah-Hartman's avatar Greg Kroah-Hartman
Browse files

driver core: make struct class.devnode() take a const * 

The devnode() in struct class should not be modifying the device that is
passed into it, so mark it as a const * and propagate the function
signature changes out into all relevant subsystems that use this
callback.

Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: Reinette Chatre <reinette.chatre@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: x86@kernel.org
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Justin Sanders <justin@coraid.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc: Liam Mark <lmark@codeaurora.org>
Cc: Laura Abbott <labbott@redhat.com>
Cc: Brian Starkey <Brian.Starkey@arm.com>
Cc: John Stultz <jstultz@google.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Leon Romanovsky <leon@kernel.org>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Sean Young <sean@mess.org>
Cc: Frank Haverkamp <haver@linux.ibm.com>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: Alex Williamson <alex.williamson@redhat.com>
Cc: Cornelia Huck <cohuck@redhat.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Anton Vorontsov <anton@enomsg.org>
Cc: Colin Cross <ccross@android.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.com>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Xie Yongji <xieyongji@bytedance.com>
Cc: Gautam Dawar <gautam.dawar@xilinx.com>
Cc: Dan Carpenter <error27@gmail.com>
Cc: Eli Cohen <elic@nvidia.com>
Cc: Parav Pandit <parav@nvidia.com>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: alsa-devel@alsa-project.org
Cc: dri-devel@lists.freedesktop.org
Cc: kvm@vger.kernel.org
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-block@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-rdma@vger.kernel.org
Cc: linux-scsi@vger.kernel.org
Cc: linux-usb@vger.kernel.org
Cc: virtualization@lists.linux-foundation.org
Link: https://lore.kernel.org/r/20221123122523.1332370-2-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 23680f0b

arch/x86/kernel/cpu/resctrl/pseudo_lock.c

+2 −2
Original line number Diff line number Diff line
@@ -1560,9 +1560,9 @@ static const struct file_operations pseudo_lock_dev_fops = { 
	.mmap =		pseudo_lock_dev_mmap,

};



static char *pseudo_lock_devnode(struct device *dev, umode_t *mode)

static char *pseudo_lock_devnode(const struct device *dev, umode_t *mode)

{

	struct rdtgroup *rdtgrp;

	const struct rdtgroup *rdtgrp;



	rdtgrp = dev_get_drvdata(dev);

	if (mode)

arch/x86/kernel/cpuid.c

+1 −1
Original line number Diff line number Diff line
@@ -139,7 +139,7 @@ static int cpuid_device_destroy(unsigned int cpu) 
	return 0;

}



static char *cpuid_devnode(struct device *dev, umode_t *mode)

static char *cpuid_devnode(const struct device *dev, umode_t *mode)

{

	return kasprintf(GFP_KERNEL, "cpu/%u/cpuid", MINOR(dev->devt));

}

arch/x86/kernel/msr.c

+1 −1
Original line number Diff line number Diff line
@@ -250,7 +250,7 @@ static int msr_device_destroy(unsigned int cpu) 
	return 0;

}



static char *msr_devnode(struct device *dev, umode_t *mode)

static char *msr_devnode(const struct device *dev, umode_t *mode)

{

	return kasprintf(GFP_KERNEL, "cpu/%u/msr", MINOR(dev->devt));

}

block/bsg.c

+1 −1
Original line number Diff line number Diff line
@@ -232,7 +232,7 @@ struct bsg_device *bsg_register_queue(struct request_queue *q, 
}

EXPORT_SYMBOL_GPL(bsg_register_queue);



static char *bsg_devnode(struct device *dev, umode_t *mode)

static char *bsg_devnode(const struct device *dev, umode_t *mode)

{

	return kasprintf(GFP_KERNEL, "bsg/%s", dev_name(dev));

}

drivers/block/aoe/aoechr.c

+1 −1
Original line number Diff line number Diff line
@@ -273,7 +273,7 @@ static const struct file_operations aoe_fops = { 
	.llseek = noop_llseek,

};



static char *aoe_devnode(struct device *dev, umode_t *mode)

static char *aoe_devnode(const struct device *dev, umode_t *mode)

{

	return kasprintf(GFP_KERNEL, "etherd/%s", dev_name(dev));

}