Commit ff2557b7 authored by Ming Lei's avatar Ming Lei Committed by Jens Axboe
Browse files

io_uring: pass correct parameters to io_req_set_res 



The two parameters of 'res' and 'cflags' are swapped, so fix it.
Without this fix, 'ublk del' hangs forever.

Cc: Pavel Begunkov <asml.silence@gmail.com>
Fixes: de23077e ("io_uring: set completion results upfront")
Signed-off-by: default avatarMing Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20220803120757.1668278-1-ming.lei@redhat.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent e2b54210

io_uring/uring_cmd.c

+1 −1
Original line number Diff line number Diff line
@@ -46,7 +46,7 @@ void io_uring_cmd_done(struct io_uring_cmd *ioucmd, ssize_t ret, ssize_t res2) 
	if (ret < 0)

		req_set_fail(req);



	io_req_set_res(req, 0, ret);

	io_req_set_res(req, ret, 0);

	if (req->ctx->flags & IORING_SETUP_CQE32)

		io_req_set_cqe32_extra(req, res2, 0);

	__io_req_complete(req, 0);