Commit ff066653 authored by Vadim Pasternak's avatar Vadim Pasternak Committed by Guenter Roeck
Browse files

hwmon: (pmbus/tps53679) Fix driver info initialization in probe routine 



Fix tps53679_probe() by using dynamically allocated "pmbus_driver_info"
structure instead of static. Usage of static structures causes
overwritten of the field "vrm_version", in case the system is equipped
with several tps53679 devices with the different "vrm_version".
In such case the last probed device overwrites this field for all
others.

Fixes: 61052652 ("hwmon: (pmbus) Add support for Texas Instruments tps53679 device")
Signed-off-by: default avatarVadim Pasternak <vadimp@mellanox.com>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent a3b22b9f

drivers/hwmon/pmbus/tps53679.c

+8 −1
Original line number Diff line number Diff line
@@ -80,7 +80,14 @@ static struct pmbus_driver_info tps53679_info = { 
static int tps53679_probe(struct i2c_client *client,

			  const struct i2c_device_id *id)

{

	return pmbus_do_probe(client, id, &tps53679_info);

	struct pmbus_driver_info *info;



	info = devm_kmemdup(&client->dev, &tps53679_info, sizeof(*info),

			    GFP_KERNEL);

	if (!info)

		return -ENOMEM;



	return pmbus_do_probe(client, id, info);

}



static const struct i2c_device_id tps53679_id[] = {