Commit fed1b6a0 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Vinod Koul
Browse files

dmaengine: ti: k3-udma: Fix a resource leak in an error handling path 



In 'dma_pool_create()', we return -ENOMEM, but don't release the resources
already allocated, as in all the other error handling paths.

Go to 'err_res_free' instead of returning directly.

Fixes: 01779473 ("dmaengine: ti: k3-udma: Initial support for K3 BCDMA")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: default avatarPeter Ujfalusi <peter.ujfalusi@gmail.com>
Link: https://lore.kernel.org/r/20210124070923.724479-1-christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent e5944431

drivers/dma/ti/k3-udma.c

+2 −1
Original line number Diff line number Diff line
@@ -2401,7 +2401,8 @@ static int bcdma_alloc_chan_resources(struct dma_chan *chan) 
			dev_err(ud->ddev.dev,

				"Descriptor pool allocation failed\n");

			uc->use_dma_pool = false;

			return -ENOMEM;

			ret = -ENOMEM;

			goto err_res_free;

		}



		uc->use_dma_pool = true;