Commit fec356a6 authored by Wu Bo's avatar Wu Bo Committed by Christoph Hellwig
Browse files

nvmet: fix memory leak in nvmet_alloc_ctrl() 



When creating ctrl in nvmet_alloc_ctrl(), if the cntlid_min is larger
than cntlid_max of the subsystem, and jumps to the
"out_free_changed_ns_list" label, but the ctrl->sqs lack of be freed.
Fix this by jumping to the "out_free_sqs" label.

Fixes: 94a39d61 ("nvmet: make ctrl-id configurable")
Signed-off-by: default avatarWu Bo <wubo40@huawei.com>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 4bc20823

drivers/nvme/target/core.c

+1 −1
Original line number Diff line number Diff line
@@ -1372,7 +1372,7 @@ u16 nvmet_alloc_ctrl(const char *subsysnqn, const char *hostnqn, 
		goto out_free_changed_ns_list;



	if (subsys->cntlid_min > subsys->cntlid_max)

		goto out_free_changed_ns_list;

		goto out_free_sqs;



	ret = ida_simple_get(&cntlid_ida,

			     subsys->cntlid_min, subsys->cntlid_max,