Commit fe70f2c8 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Greg Kroah-Hartman
Browse files

usb: phy: ab8500: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230319092428.283054-2-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fcd3f508

drivers/usb/phy/phy-ab8500-usb.c

+2 −4
Original line number Original line Diff line number Diff line
@@ -965,7 +965,7 @@ static int ab8500_usb_probe(struct platform_device *pdev) 
	return 0;

	return 0;

}

}





static int ab8500_usb_remove(struct platform_device *pdev)

static void ab8500_usb_remove(struct platform_device *pdev)

{

{

	struct ab8500_usb *ab = platform_get_drvdata(pdev);

	struct ab8500_usb *ab = platform_get_drvdata(pdev);
@@ -977,8 +977,6 @@ static int ab8500_usb_remove(struct platform_device *pdev) 
		ab8500_usb_host_phy_dis(ab);

		ab8500_usb_host_phy_dis(ab);

	else if (ab->mode == USB_PERIPHERAL)

	else if (ab->mode == USB_PERIPHERAL)

		ab8500_usb_peri_phy_dis(ab);

		ab8500_usb_peri_phy_dis(ab);



	return 0;

}

}





static const struct platform_device_id ab8500_usb_devtype[] = {

static const struct platform_device_id ab8500_usb_devtype[] = {
@@ -989,7 +987,7 @@ MODULE_DEVICE_TABLE(platform, ab8500_usb_devtype); 




static struct platform_driver ab8500_usb_driver = {

static struct platform_driver ab8500_usb_driver = {

	.probe		= ab8500_usb_probe,

	.probe		= ab8500_usb_probe,

	.remove		= ab8500_usb_remove,

	.remove_new	= ab8500_usb_remove,

	.id_table	= ab8500_usb_devtype,

	.id_table	= ab8500_usb_devtype,

	.driver		= {

	.driver		= {

		.name	= "abx5x0-usb",

		.name	= "abx5x0-usb",