Commit fe5b3ce8 authored by Yang Yingliang's avatar Yang Yingliang Committed by Paolo Abeni
Browse files

stmmac: dwmac-loongson: fix missing pci_disable_device() in loongson_dwmac_probe() 



Add missing pci_disable_device() in the error path in loongson_dwmac_probe().

Fixes: 30bba69d ("stmmac: pci: Add dwmac support for Loongson")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent f2d45fdf

drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c

+5 −2
Original line number Diff line number Diff line
@@ -97,7 +97,7 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id 
			continue;

		ret = pcim_iomap_regions(pdev, BIT(0), pci_name(pdev));

		if (ret)

			return ret;

			goto err_disable_device;

		break;

	}
@@ -108,7 +108,8 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id 
	phy_mode = device_get_phy_mode(&pdev->dev);

	if (phy_mode < 0) {

		dev_err(&pdev->dev, "phy_mode not found\n");

		return phy_mode;

		ret = phy_mode;

		goto err_disable_device;

	}



	plat->phy_interface = phy_mode;
@@ -149,6 +150,8 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id 


err_disable_msi:

	pci_disable_msi(pdev);

err_disable_device:

	pci_disable_device(pdev);

	return ret;

}