Commit fe3333f6 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jens Axboe
Browse files

ublk_drv: fix an IS_ERR() vs NULL check 



The blk_mq_alloc_disk_for_queue() doesn't return error pointers, it
returns NULL on error.

Fixes: cebbe577 ("ublk_drv: fix request queue leak")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarMing Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/YtVAgedTsQVK1oTM@kili


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent d276a223

drivers/block/ublk_drv.c

+2 −2
Original line number Diff line number Diff line
@@ -1174,8 +1174,8 @@ static int ublk_add_dev(struct ublk_device *ub) 


	disk = ub->ub_disk = blk_mq_alloc_disk_for_queue(ub->ub_queue,

						 &ublk_bio_compl_lkclass);

	if (IS_ERR(disk)) {

		err = PTR_ERR(disk);

	if (!disk) {

		err = -ENOMEM;

		goto out_free_request_queue;

	}