Commit fe26821f authored by Florian Fainelli's avatar Florian Fainelli Committed by David S. Miller
Browse files

net: phy: broadcom: Wire suspend/resume for BCM54810 



The BCM54810 PHY can use the standard BMCR Power down suspend, but needs
a custom resume routine which first clear the Power down bit, and then
re-initializes the PHY. While in low-power mode, the PHY only accepts
writes to the BMCR register. The datasheet clearly says it:

Reads or writes to any MII register other than MII Control register
(address 00h) while the device is in the standby power-down mode may
cause unpredictable results.

Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent cb64da3a

drivers/net/phy/broadcom.c

+16 −0
Original line number Diff line number Diff line
@@ -313,6 +313,20 @@ static int bcm54xx_config_init(struct phy_device *phydev) 
	return 0;

}



static int bcm54xx_resume(struct phy_device *phydev)

{

	int ret;



	/* Writes to register other than BMCR would be ignored

	 * unless we clear the PDOWN bit first

	 */

	ret = genphy_resume(phydev);

	if (ret < 0)

		return ret;



	return bcm54xx_config_init(phydev);

}



static int bcm5482_config_init(struct phy_device *phydev)

{

	int err, reg;
@@ -706,6 +720,8 @@ static struct phy_driver broadcom_drivers[] = { 
	.config_aneg    = bcm5481_config_aneg,

	.ack_interrupt  = bcm_phy_ack_intr,

	.config_intr    = bcm_phy_config_intr,

	.suspend	= genphy_suspend,

	.resume		= bcm54xx_resume,

}, {

	.phy_id		= PHY_ID_BCM5482,

	.phy_id_mask	= 0xfffffff0,