Unverified Commit fe1e7e8c authored by Alexey Firago's avatar Alexey Firago Committed by Mark Brown
Browse files

ASoC: codecs: es8326: Fix DTS properties reading 



Seems like properties parsing and reading was copy-pasted,
so "everest,interrupt-src" and "everest,interrupt-clk" are saved into
the es8326->jack_pol variable. This might lead to wrong settings
being saved into the reg 57 (ES8326_HP_DET).

Fix this by using proper variables while reading properties.

Signed-off-by: default avatarAlexey Firago <a.firago@yadro.com>
Reviewed-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20230204195106.46539-1-a.firago@yadro.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 2e7c6652

sound/soc/codecs/es8326.c

+4 −2
Original line number Diff line number Diff line
@@ -729,14 +729,16 @@ static int es8326_probe(struct snd_soc_component *component) 
	}

	dev_dbg(component->dev, "jack-pol %x", es8326->jack_pol);



	ret = device_property_read_u8(component->dev, "everest,interrupt-src", &es8326->jack_pol);

	ret = device_property_read_u8(component->dev, "everest,interrupt-src",

				      &es8326->interrupt_src);

	if (ret != 0) {

		dev_dbg(component->dev, "interrupt-src return %d", ret);

		es8326->interrupt_src = ES8326_HP_DET_SRC_PIN9;

	}

	dev_dbg(component->dev, "interrupt-src %x", es8326->interrupt_src);



	ret = device_property_read_u8(component->dev, "everest,interrupt-clk", &es8326->jack_pol);

	ret = device_property_read_u8(component->dev, "everest,interrupt-clk",

				      &es8326->interrupt_clk);

	if (ret != 0) {

		dev_dbg(component->dev, "interrupt-clk return %d", ret);

		es8326->interrupt_clk = 0x45;