Commit fda17afc authored by Damien Le Moal's avatar Damien Le Moal
Browse files

ata: libata-core: Fix ata_dev_config_cpr() 

The concurrent positioning ranges log page 47h is a general purpose log
page and not a subpage of the indentify device log. Using
ata_identify_page_supported() to test for concurrent positioning ranges
support is thus wrong. ata_log_supported() must be used.

Furthermore, unlike other advanced ATA features (e.g. NCQ priority),
accesses to the concurrent positioning ranges log page are not gated by
a feature bit from the device IDENTIFY data. Since many older drives
react badly to the READ LOG EXT and/or READ LOG DMA EXT commands isued
to read device log pages, avoid problems with older drives by limiting
the concurrent positioning ranges support detection to drives
implementing at least the ACS-4 ATA standard (major version 11). This
additional condition effectively turns ata_dev_config_cpr() into a nop
for older drives, avoiding problems in the field.

Fixes: fe22e1c2 ("libata: support concurrent positioning ranges log")
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=215519


Cc: stable@vger.kernel.org
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Tested-by: default avatarAbderraouf Adjal <adjal.arf@gmail.com>
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
parent dfd42fac

drivers/ata/libata-core.c

+6 −8
Original line number Diff line number Diff line
@@ -2448,23 +2448,21 @@ static void ata_dev_config_cpr(struct ata_device *dev) 
	struct ata_cpr_log *cpr_log = NULL;

	u8 *desc, *buf = NULL;



	if (!ata_identify_page_supported(dev,

				 ATA_LOG_CONCURRENT_POSITIONING_RANGES))

	if (ata_id_major_version(dev->id) < 11 ||

	    !ata_log_supported(dev, ATA_LOG_CONCURRENT_POSITIONING_RANGES))

		goto out;



	/*

	 * Read IDENTIFY DEVICE data log, page 0x47

	 * (concurrent positioning ranges). We can have at most 255 32B range

	 * descriptors plus a 64B header.

	 * Read the concurrent positioning ranges log (0x47). We can have at

	 * most 255 32B range descriptors plus a 64B header.

	 */

	buf_len = (64 + 255 * 32 + 511) & ~511;

	buf = kzalloc(buf_len, GFP_KERNEL);

	if (!buf)

		goto out;



	err_mask = ata_read_log_page(dev, ATA_LOG_IDENTIFY_DEVICE,

				     ATA_LOG_CONCURRENT_POSITIONING_RANGES,

				     buf, buf_len >> 9);

	err_mask = ata_read_log_page(dev, ATA_LOG_CONCURRENT_POSITIONING_RANGES,

				     0, buf, buf_len >> 9);

	if (err_mask)

		goto out;

include/linux/ata.h

+1 −1
Original line number Diff line number Diff line
@@ -324,12 +324,12 @@ enum { 
	ATA_LOG_NCQ_NON_DATA	= 0x12,

	ATA_LOG_NCQ_SEND_RECV	= 0x13,

	ATA_LOG_IDENTIFY_DEVICE	= 0x30,

	ATA_LOG_CONCURRENT_POSITIONING_RANGES = 0x47,



	/* Identify device log pages: */

	ATA_LOG_SECURITY	  = 0x06,

	ATA_LOG_SATA_SETTINGS	  = 0x08,

	ATA_LOG_ZONED_INFORMATION = 0x09,

	ATA_LOG_CONCURRENT_POSITIONING_RANGES = 0x47,



	/* Identify device SATA settings log:*/

	ATA_LOG_DEVSLP_OFFSET	  = 0x30,