Unverified Commit fd829918 authored by Pan Xiuli's avatar Pan Xiuli Committed by Mark Brown
Browse files

ASoC: SOF: intel: fix wrong poll bits in dsp power down 



The ADSPCS_SPA is Set Power Active bit. To check if DSP is powered
down, we need to check ADSPCS_CPA, the Current Power Active bit.

Fixes: 747503b1 ("ASoC: SOF: Intel: Add Intel specific HDA DSP HW operations")
Reviewed-by: default avatarRander Wang <rander.wang@intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: default avatarPan Xiuli <xiuli.pan@linux.intel.com>
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210309004127.4940-1-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 7c2a783c

sound/soc/sof/intel/hda-dsp.c

+1 −1
Original line number Diff line number Diff line
@@ -207,7 +207,7 @@ int hda_dsp_core_power_down(struct snd_sof_dev *sdev, unsigned int core_mask) 


	ret = snd_sof_dsp_read_poll_timeout(sdev, HDA_DSP_BAR,

				HDA_DSP_REG_ADSPCS, adspcs,

				!(adspcs & HDA_DSP_ADSPCS_SPA_MASK(core_mask)),

				!(adspcs & HDA_DSP_ADSPCS_CPA_MASK(core_mask)),

				HDA_DSP_REG_POLL_INTERVAL_US,

				HDA_DSP_PD_TIMEOUT * USEC_PER_MSEC);

	if (ret < 0)