Commit fd7f8c32 authored by Jonas Dreßler's avatar Jonas Dreßler Committed by Kalle Valo
Browse files

mwifiex: Log an error on command failure during key-material upload



Sometimes the KEY_MATERIAL command can fail with the 88W8897 firmware
(when this happens exactly seems pretty random). This appears to prevent
the access point from starting, so it seems like a good idea to log an
error in that case.

Signed-off-by: default avatarJonas Dreßler <verdre@v0yd.nl>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20211016153244.24353-3-verdre@v0yd.nl
parent 03893e93
Loading
Loading
Loading
Loading
+8 −2
Original line number Diff line number Diff line
@@ -519,8 +519,14 @@ mwifiex_cfg80211_set_default_mgmt_key(struct wiphy *wiphy,
	encrypt_key.is_igtk_def_key = true;
	eth_broadcast_addr(encrypt_key.mac_addr);

	return mwifiex_send_cmd(priv, HostCmd_CMD_802_11_KEY_MATERIAL,
				HostCmd_ACT_GEN_SET, true, &encrypt_key, true);
	if (mwifiex_send_cmd(priv, HostCmd_CMD_802_11_KEY_MATERIAL,
			     HostCmd_ACT_GEN_SET, true, &encrypt_key, true)) {
		mwifiex_dbg(priv->adapter, ERROR,
			    "Sending KEY_MATERIAL command failed\n");
		return -1;
	}

	return 0;
}

/*